Correct highlighting for multiple regexps #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raxod502
changed the title
basil-conto
reviewed
May 27, 2018
ivy.el
Outdated
| (cl-remove-if | ||
| (lambda (regexp-cons) | ||
| (null (cdr regexp-cons))) | ||
| ivy--old-re)) |
There was a problem hiding this comment.
Why not
(cl-mapcan (lambda (cell)
(and (cdr cell)
(list (car cell))))
ivy--old-re)or, at the very least,
(mapcar #'car (cl-remove-if-not #'cdr ivy--old-re))(Guaranteed 100% untested, mind you.)
swiper.el
Outdated
| (cl-remove-if | ||
| (lambda (regexp-cons) | ||
| (null (cdr regexp-cons))) | ||
| regexp-or-regexps)) |
|
Fixed, thanks. |
|
I only looked at them briefly, but I think this pull request solves both of those issues. Namely, all subparts of the search query are highlighted in the minibuffer, without having to update I used both functionalities in
|
As did I, hence the lazy question. :)
Happy days! Even if this PR doesn't iron out their every kink, you can probably still mention them in the commit message. |
Fixes abo-abo#654. Fixes abo-abo#1550. Supersedes abo-abo#1551.
raxod502
force-pushed
the
feat/swiper-multiple-regexps
branch
from
c827477
to
b4fac8b
Compare
|
OK, done :) |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654.
This was a really simple fix. (Only the
let*forms and thedolistat the beginning were touched.) So maybe I am missing something?It may also be necessary to adapt
ivy--subexpsto handle a list of integers, so that each regexp in the list may have a different number of subexpressions. That could be doable in a separate commit, depending on how important it is.